FloatingTextField added #261
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
oKcerG
reviewed
Jul 5, 2018
|
|
||
| color: Material.hintTextColor | ||
| anchors.topMargin: offset * 2 | ||
| font.pointSize: Qt.application.font.pointSize + 2 |
There was a problem hiding this comment.
Is this line needed ? Shouldn't we keep the font size the same as the textfield font size ?
There was a problem hiding this comment.
according to guideline it's needed
oKcerG
reviewed
Jul 5, 2018
| PropertyChanges { | ||
| target: placeholder | ||
|
|
||
| font.pointSize: Qt.application.font.pointSize |
There was a problem hiding this comment.
using font.pointSize makes the animation choppy here, maybe use scale instead ?
There was a problem hiding this comment.
This works on my linux and windows systems
NumberAnimation {
properties: "anchors.topMargin,font.pointSize"
duration: Units.shortDuration
easing.type: Easing.InOutQuad
}| import QtQuick 2.11 | ||
| import QtQuick.Controls 2.4 | ||
| import QtQuick.Controls.Material 2.4 | ||
| import QtQuick.Templates 2.4 as T |
There was a problem hiding this comment.
keep the import version compatible with Qt 5.10 ?
2.10 and 2.3
There was a problem hiding this comment.
didn't think about that, I'm using latest qt. I'm not sure it's necessary to support 5.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
test (or a benchmark) included?
existing APIs, or introduces new ones)
Affected core subsystem(s)
Controls
Description of change
Inherits QQC2.Templates.TextField like default QQC2.Controls.TextField with placeholder behaviour changes as described here #253.
Material.Grey changed to Material.hintTextColor.
Also I still don't know how to use it :) (#259)