Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codes for Daikin FWT-GT on Broadlink #131

Merged

Conversation

darcato
Copy link

@darcato darcato commented Sep 10, 2024

This adds IR codes for Daikin FWT-GT fan coil on Broadlink.
It's the same fan coil as #101 . The upstream repo has a similar PR: smartHomeHub#1162 but this is more complete.

I decoded the daikin protocol and used it to generate the codes: https://github.com/darcato/daikin-fwt-gt-ir-code

Copy link
Owner

@litinoveweedle litinoveweedle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello,

it seems that there are repeating commands:

    "low": {
      "fixed": {
        "16": "JgCWAAABOwABPgABPAABPpVRCg0LHwsfCg0LHwoNCg0KDQoNCg0KDQsfCg0KDQoNCx8KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0LHwsfCg0LHwoNCg0KDQoNCg0LHwoNCg0LHwoNCg0LAAKRlAANBQ==",
        "17": "JgCWAAABOwABPgABPAABPpVRCg0LHwsfCg0LHwoNCg0KDQoNCg0KDQsfCg0KDQoNCx8KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCg0KDQoNCx8LHwsfCg0LHwoNCg0KDQoNCg0LHwoNCx8LHwoNCg0LAAKRlAANBQ==",

This could be replaced by catch-all syntax more elegantly. Would you please consider it? https://github.com/litinoveweedle/SmartIR/blob/master/docs/CODES_SYNTAX.md#climate-operation-commands

@darcato
Copy link
Author

darcato commented Sep 16, 2024

Actually those commands are not the same. All the commands are unique, except the on and off which are the same.

@litinoveweedle litinoveweedle merged commit a7cc5e8 into litinoveweedle:master Sep 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants