Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Fault Node Status to RUNNING on Experiment Start #4733

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

andoriyaprashant
Copy link

@andoriyaprashant andoriyaprashant commented Jun 28, 2024

Fixes #4724

Proposed changes

Previously, fault node statuses in ChaosEngine events often remained stuck at INITIALIZED during experiment execution, resulting in inaccurate state reporting. The update introduces refined status transition mechanisms to ensure precise tracking and reporting of ChaosEngine states, specifically addressing transitions from INITIALIZED to RUNNING.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

@namkyu1999
Copy link
Member

Hi @andoriyaprashant, can you check broken pipelines?

shovanmaity and others added 12 commits July 6, 2024 12:35
* update allowed origins list

Signed-off-by: Shovan Maity <shovan.maity@harness.io>

* update nginx config

Signed-off-by: Shovan Maity <shovan.maity@harness.io>

* add manifest changes

Signed-off-by: Shovan Maity <shovan.maity@harness.io>

* update local value of allowed origins

Signed-off-by: Shovan Maity <shovan.maity@harness.io>

---------

Signed-off-by: Shovan Maity <shovan.maity@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
…chaos#4670)

* Added strict validation for username and password in backend.

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* fixed silly mistake

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* some requested changes.

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* modified tests

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* small change

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* Update message string in chaoscenter/authentication/api/handlers/doc.go

Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io>
Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>

* Update error message chaoscenter/authentication/pkg/utils/sanitizers.go

Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io>
Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>

* Modified swagger with requested changes.

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* added negative tests for requested functions and fixed some conflicts.

Signed-off-by: aryan <aryan1bhokare@gmail.com>

---------

Signed-off-by: aryan <aryan1bhokare@gmail.com>
Signed-off-by: Aryan Bhokare <92683836+aryan-bhokare@users.noreply.github.com>
Co-authored-by: Vedant Shrotria <vedant.shrotria@harness.io>
Co-authored-by: Saranya Jena <saranya.jena@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
* Refactor editor to executer in Authentication service.

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* Refactor editor to executer in GraphQl servers.

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* Changing executor roles.

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* Updation in frontend hooks corresponding to backend refactor.

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* Executer role implementation.

Converted editor roles to executer role in frontend files. And Changed rbacs of the new Executer role.

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* modification of api specs for executor

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* removed executor role from userInfraRegistration and fixed import orders.

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* refactor executer to executor

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* Removing exector permission from launch experiment FE

Signed-off-by: aryan <aryan1bhokare@gmail.com>

* minor fix

Signed-off-by: aryan <aryan1bhokare@gmail.com>

---------

Signed-off-by: aryan <aryan1bhokare@gmail.com>
Co-authored-by: Namkyu Park <53862866+namkyu1999@users.noreply.github.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
…itmuschaos#4744)

* feat: Added password reset as a route to manage initial login case

Signed-off-by: Hrishav <hrishav.kumar@harness.io>

* feat: Fixed deepspan issue

Signed-off-by: Hrishav <hrishav.kumar@harness.io>

* fix: Updated API response in front-end

Signed-off-by: Hrishav <hrishav.kumar@harness.io>

* chore: addressed review comment

Signed-off-by: Hrishav <hrishav.kumar@harness.io>

---------

Signed-off-by: Hrishav <hrishav.kumar@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
…itmuschaos#4719)

* Added support for jwt secret creation of each user upon logic

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* Fixed imports

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* Add fixes in dex service

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* Fixed UTs

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* resolved comments

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* updated logic

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* fixed UTs and removed unecessary test cases

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* fixed imports

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* fixed imports

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* resolved comments

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* fixed imports

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* resolved comments

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* added server endpoint in allowed origins

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* fixed imports

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* minor chnages

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* minor chnages

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

* fixed imports

Signed-off-by: Saranya-jena <saranya.jena@harness.io>

---------

Signed-off-by: Saranya-jena <saranya.jena@harness.io>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Signed-off-by: andoriyaprashant <prashantandoriya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fault node status doesn't go to RUNNING state during experiment execution
6 participants