Skip to content

Commit

Permalink
- changed the type from string to integer for the setter und getter o… (
Browse files Browse the repository at this point in the history
#211)

* - changed the type from string to integer for the setter und getter of the voiceBridge

* - codestyle fix in the URLBuilder class

---------

Co-authored-by: Felix Jacobi <felix@jacobi-hamburg.net>
  • Loading branch information
marineusde and FelixJacobi authored Sep 13, 2024
1 parent 672f881 commit 13fabd0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/Parameters/CreateMeetingParameters.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@
* @method $this setWelcome(string $welcome)
* @method string getDialNumber()
* @method $this setDialNumber(string $dialNumber)
* @method string getVoiceBridge()
* @method $this setVoiceBridge(string $voiceBridge)
* @method int getVoiceBridge()
* @method $this setVoiceBridge(int $voiceBridge)
* @method string getWebVoice()
* @method $this setWebVoice(string $webVoice)
* @method int getMaxParticipants()
Expand Down
2 changes: 1 addition & 1 deletion src/Util/UrlBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ final class UrlBuilder
public function __construct(
private readonly string $securitySalt,
private readonly string $bbbServerBaseUrl,
private readonly HashingAlgorithm $hashingAlgorithm
private readonly HashingAlgorithm $hashingAlgorithm,
) {
}

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/BigBlueButtonTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ public function testGetMeetings(): void
$this->assertEquals('12345', $response->getMeetings()[0]->getInternalMeetingId());
$this->assertEquals(1531241258036, $response->getMeetings()[0]->getCreationTime());
$this->assertEquals('Tue Jul 10 16:47:38 UTC 2018', $response->getMeetings()[0]->getCreationDate());
$this->assertEquals('70066', $response->getMeetings()[0]->getVoiceBridge());
$this->assertEquals(70066, $response->getMeetings()[0]->getVoiceBridge());
$this->assertEquals('613-555-1234', $response->getMeetings()[0]->getDialNumber());
$this->assertFalse($response->getMeetings()[0]->isRunning());
$this->assertEquals(0, $response->getMeetings()[0]->getDuration());
Expand Down

0 comments on commit 13fabd0

Please sign in to comment.