Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- getting the internal meeting-id from the meeting of the recording #208

Merged

Conversation

marineusde
Copy link

If the user or a plugin create more than 1 meeting with the same meetingId, we got records from the false meeting. So I have to check the "internal Meeting-ID" of the recording with the meeting after getting from the api.

This merge request extends the Record class with the "internalMeetingId" of the recording.

@FelixJacobi
Copy link
Member

Hello @marineusde! 👋🏼

Thank you for your contribution. Could please rebase your PR against master which recently became 6.x? We introduced stricter coding rules there, tools/rector process src/ should help you to apply them correctly. Also, could you please add your new method to the respective test please?

Thanks!

@FelixJacobi FelixJacobi added this to the 6.1 milestone Aug 23, 2024
@marineusde
Copy link
Author

Hello @marineusde! 👋🏼

Thank you for your contribution. Could please rebase your PR against master which recently became 6.x? We introduced stricter coding rules there, tools/rector process src/ should help you to apply them correctly. Also, could you please add your new method to the respective test please?

Thanks!

Oh, 6.x was released :O

First I will test the new version in our project, then I will rebase the code to this.

@marineusde marineusde force-pushed the record-with-internal-meeting-id branch from 9f157a1 to a7b0e04 Compare August 26, 2024 08:52
@marineusde
Copy link
Author

@FelixJacobi I rebased now the branch

@FelixJacobi
Copy link
Member

@FelixJacobi I rebased now the branch

LGTM, thanks. Could you extend the tests please. Then, we can merge, I think ;) .

@marineusde marineusde force-pushed the record-with-internal-meeting-id branch from a7b0e04 to ac9cebc Compare August 27, 2024 06:33
@marineusde
Copy link
Author

marineusde commented Aug 27, 2024

@FelixJacobi I rebased now the branch

LGTM, thanks. Could you extend the tests please. Then, we can merge, I think ;) .

done

Is it possible to release a new version 6.1 in the next days? Its a very huge problem for us in the moment, that we get the "wrong" recordings for a meeting, cause ILIAS- and Moodle-Plugins reuse the name for their meetingId in different meetings.

If you want, I can help you with the other issues for the version 6.2 ;)

@FelixJacobi FelixJacobi merged commit 672f881 into littleredbutton:master Sep 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants