Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] try use buf to build the bigtable proto #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 4 additions & 12 deletions bigtable_rs/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -12,19 +12,16 @@ readme = "../README.md"
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[dependencies]
# tonic, prost, and prost-types are need for build generated rs files
bytes = "1.9.0"
http = "1.1.0"
hyper-util = { version = "0.1.7", features = ["tokio"] }
tokio = { version = "1.25.0", features = ["rt-multi-thread"] }
tonic = { version = "0.12.2", features = ["tls", "transport"] }
tower = { version = "0.5.1", features = ["util"] }
prost = "0.13.1"
prost-types = "0.13.1"
prost-wkt = { version = "0.6.0" }
prost-wkt-types = { version = "0.6.0" }
serde = { version = "1.0.192", features = ["derive"] }
serde_with = { version = "3.4.0", features = ["base64"] }
# end of above part
pbjson = "0.7"
pbjson-types = "0.7"
futures-util = "0.3.31"
gcp_auth = "0.12.2"
log = "0.4.20"
Expand All @@ -33,9 +30,4 @@ thiserror = "2.0.3"
[dev-dependencies]
env_logger = "0.11.1"
serde_json = "1.0.85"
serde_path_to_error = "0.1.8"

[build-dependencies]
tonic-build = { version = "0.12.2", features = ["cleanup-markdown"] }
prost-build = "0.13.1"
prost-wkt-build = { version = "0.6.0" }
serde_path_to_error = "0.1.16"
111 changes: 0 additions & 111 deletions bigtable_rs/build.rs

This file was deleted.

7 changes: 5 additions & 2 deletions bigtable_rs/src/bigtable/read_rows.rs
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,11 @@ pub fn decode_read_rows_response_to_vec(
// Close up the cell
if cell_name.is_some() {
let row_cell = RowCell {
family_name: cell_family_name.clone().unwrap_or("".to_owned()),
qualifier: cell_name.clone().unwrap(), // checked above
family_name: cell_family_name
.clone()
.map(|n| n.value)
.unwrap_or("".to_owned()),
qualifier: cell_name.clone().unwrap().value.to_vec(), // checked above
value: cell_value,
timestamp_micros: cell_timestamp,
labels: cell_labels,
Expand Down
24 changes: 0 additions & 24 deletions bigtable_rs/src/google.rs

This file was deleted.

Loading
Loading