Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add participant_disconnect and unlink methods, to reconnect human input #1125

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

brightsparc
Copy link
Contributor

@brightsparc brightsparc commented Nov 22, 2024

Fixes: #1124

This adds new method to disconnect a participant and refactors the inner methods to be class level.

  • May want to review diff without whitespace since I've moved some internal methods up a level
  • The type checking required me to explicitly reference vad.VADEvent and stt.SpeechEvent

cc @theomonnom

Copy link

changeset-bot bot commented Nov 22, 2024

🦋 Changeset detected

Latest commit: fcca167

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-agents Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brightsparc brightsparc changed the title Add participant_disconnect and unlink methods for human input fix: Add participant_disconnect and unlink methods, to reconnect human input Nov 22, 2024
@brightsparc
Copy link
Contributor Author

Thanks @theomonnom, could we get this merged so it makes it into the next release?

@theomonnom
Copy link
Member

Hey @brightsparc, probably sometimes this week, we're thinking about reworking this flow a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Participant is not unlinked during disconnection, so human input is out of sync
2 participants