Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: added trigger-phrase agent example #800
base: main
Are you sure you want to change the base?
examples: added trigger-phrase agent example #800
Changes from 6 commits
7aa7d6a
1586f1a
a46d719
fdbf951
f53750a
5a40f49
f9e8c03
5b03b63
a7dd4b5
807ab6b
758acbe
e09049f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check failure on line 19 in examples/trigger-phrase/agent.py
GitHub Actions / build
Ruff (I001)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
TRIGGER_PHRASE
instead to show that this is a changeable constantThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh okay, didn't know that - thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should have this be in the prewarm function so it doesn't block the job from starting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oope I see it in the docs now, should have read it better 🤦♂️
Check failure on line 123 in examples/trigger-phrase/agent.py
GitHub Actions / build
Ruff (F841)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird misleading use of trigger_phrase here. this implies that it can only be used as a name, i think it's best to drop it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I agree. I was also debating about this but my thought was that it might be helpful to give the LLM a bit more context