Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recording room composite before video is decoded #806

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

davidzhao
Copy link
Member

It's likely to receive delta frames that are not decodable in the start. This would produce an undesirable black screen in the beginning of the recording.

It's likely to receive delta frames that are not decodable in
the start. This would produce an undesirable black screen in the beginning of the recording.
@davidzhao davidzhao requested a review from a team as a code owner November 12, 2024 08:03
@biglittlebigben
Copy link
Contributor

This means we'll potentially cut some audio from the start of the recording, until a video becomes decodable. Is this always desirable?

I can also see how a few customers may have a broken setup where they publish a video track but never send any video so we'd want to advertise this change pretty explicitly in the changelog.

@davidzhao
Copy link
Member Author

It's a tricky one for sure. these are the use cases:

  1. video users do not want to record a black screen as the initial thumbnail
  2. audio-only users should work immediately
  3. edge cases like having a video published, but no frames coming through

before this PR, it doesn't satisfy 1, which is where users have been complaining about.

For 2, we should move this to mixing within the process, instead of using templates for them.

  1. may still be an issue, and I think it's handled by adding a timeout (one could argue 10s is too long, I'd be happy to lower it to 5s). I think if folks have custom use cases, they should host their own template. It feels kind of broken that the primary use case (recording a video) doesn't work correctly.

@davidzhao davidzhao merged commit cce6421 into main Nov 15, 2024
2 checks passed
@davidzhao davidzhao deleted the dz/avoid-black-frame branch November 15, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants