Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add live_video_to_video pipeline #233

Merged
merged 42 commits into from
Oct 28, 2024
Merged

Add live_video_to_video pipeline #233

merged 42 commits into from
Oct 28, 2024

Conversation

emranemran
Copy link
Contributor

@emranemran emranemran commented Oct 22, 2024 •
edited by leszko
Loading

Base work for the Realtime Video AI Pipeline

@j0sh
Copy link
Contributor

j0sh commented Oct 23, 2024 •
edited
Loading

Is the pipeline 'video-to-video' ? I have been calling it 'live-video-to-video' - see livepeer/go-livepeer#3210

Can the base branch be main? Easier to track and keep up to date, and it seems there is a lot of stuff in the feature/live-ai that we do not need

@j0sh j0sh mentioned this pull request Oct 24, 2024
Merged
@j0sh j0sh changed the base branch from feature/live-ai to main October 24, 2024 16:44
@emranemran emranemran marked this pull request as ready for review October 24, 2024 20:34
@j0sh
Copy link
Contributor

j0sh commented Oct 24, 2024

Fixed docker paths in b302de9 @emranemran - the commit showed up as you since it was from your machine

leszko
leszko approved these changes Oct 25, 2024
View reviewed changes
Copy link

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough to merge into main and work from there. Also it does not touch any existing code, so nothing should break :)

@j0sh
Copy link
Contributor

j0sh commented Oct 25, 2024

I like the flattening of app/python/infer into app/infer. Everything in this repo involves inference though... how about app/live since that describes the use case?

@leszko
Copy link

leszko commented Oct 28, 2024

I like the flattening of app/python/infer into app/infer. Everything in this repo involves inference though... how about app/live since that describes the use case?

I think it's a good idea. Let me rename it

@leszko leszko changed the title video_to_video plumbing Add live_video_to_video pipeline Oct 28, 2024
@leszko leszko merged commit 3e2b1ee into main Oct 28, 2024
3 checks passed
@rickstaa rickstaa deleted the emran/video-to-video-plumbing branch October 28, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leszko leszko leszko approved these changes

@rickstaa rickstaa Awaiting requested review from rickstaa rickstaa is a code owner

@j0sh j0sh Awaiting requested review from j0sh

@victorges victorges Awaiting requested review from victorges

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emranemran @j0sh @leszko @victorges