Remove workaround for minVersion #2041
leszkotest.yaml
on: pull_request
Run tests defined for the project
16m 44s
Perform CodeQL analysis
4m 8s
Run editorconfig checker
6s
Annotations
11 warnings
|
Run tests defined for the project:
cmd/simple_auth_server/simple_auth_server.go#L17
struct field Url should be URL
|
|
Run tests defined for the project:
discovery/discovery.go#L64
should omit 2nd value from range; this loop is equivalent to `for i := range ...`
|
|
Run tests defined for the project:
eth/blockwatch/block_watcher.go#L513
redefinition of the built-in function max
|
|
Run tests defined for the project:
cmd/livepeer_bench/livepeer_bench.go#L189
should replace realTimeSegCount += 1 with realTimeSegCount++
|
|
Run tests defined for the project:
eth/types/contracts.go#L49
struct field NextUnbondingLockId should be NextUnbondingLockID
|
|
Run tests defined for the project:
eth/blockwatch/stack.go#L80
redundant if ...; err != nil check, just return error instead.
|
|
Run tests defined for the project:
eth/blockwatch/fake_log_client.go#L33
parameter 'number' seems to be unused, consider removing or renaming it as _
|
|
Run tests defined for the project:
eth/blockwatch/block_watcher.go#L516
redefinition of the built-in function max
|
|
Run tests defined for the project:
discovery/stub.go#L32
exported func StubOrchestratorPool returns unexported type *discovery.stubOrchestratorPool, which can be annoying to use
|
|
Run tests defined for the project:
eth/blockwatch/block_watcher.go#L496
if block ends with a return statement, so drop this else and outdent its block
|
|
Run tests defined for the project
Unexpected input(s) 'gcov_ignore', valid inputs are ['token', 'codecov_yml_path', 'commit_parent', 'directory', 'disable_file_fixes', 'disable_search', 'disable_safe_directory', 'dry_run', 'env_vars', 'exclude', 'fail_ci_if_error', 'file', 'files', 'flags', 'git_service', 'handle_no_reports_found', 'job_code', 'name', 'network_filter', 'network_prefix', 'os', 'override_branch', 'override_build', 'override_build_url', 'override_commit', 'override_pr', 'plugin', 'plugins', 'report_code', 'root_dir', 'slug', 'url', 'use_legacy_upload_endpoint', 'use_oidc', 'verbose', 'version', 'working-directory']
|