-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit tests and enable tests in CI for ai-video #3190
Conversation
…nto rafal/ai-video-fix-unit-tests
Re: removing tests for the deprecated I think it is fine to remove the tests and to keep the commit. IIRC the problem I was trying to solve with that commit was that the AI requests would trigger a failure on the O for the call And IIRC the reason for keeping the logic for parsing the I would just recommend announcing with plenty of lead time that this will be a breaking change unlikely to affect anyone, but if you are running a old version of go-livepeer for a G you should upgrade to a more recent one that uses the other profile fields of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had some questions but apart from that looks good to me.
Changes:
segData.Profiles
@yondonfu Please double check we don't need it for video anymore (I've seen your commit here: a2b194e#diff-7157f6a8ee36dc4ada0f69ca25c9b79cbbae048dba0b4dde96270ad400d900eeL499ai-video