Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3185 unify pipeline tag #3191

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Conversation

pwilczynskiclearcode
Copy link
Contributor

What does this pull request do? Explain your changes.
Unifies the "pipeline" prometheus metric tag produced by AIRequestError

Fixes #3185

Checklist:

@pwilczynskiclearcode pwilczynskiclearcode changed the base branch from master to ai-video October 2, 2024 10:55
@pwilczynskiclearcode pwilczynskiclearcode force-pushed the 3185-unify-pipeline-tag branch 2 times, most recently from 731b972 to 5abfd40 Compare October 2, 2024 11:27
@leszko leszko self-requested a review October 21, 2024 09:39
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rickstaa should we just merge it or should we notify anyone that the label is changed?

monitor/census.go Outdated Show resolved Hide resolved
This commit ensures that the new metrics functions also use the
`normalizePipelineTag` method to ensure consistent pipeline naming in
the metrics.
Copy link
Contributor

@rickstaa rickstaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pwilczynskiclearcode Great catch! I've implemented your suggested change to the new AI remote worker metrics functions. One additional point to consider is whether we want to ensure consistent behavior in the ai_process.go file. Currently, we're inserting a capability string instead of a pipeline string, as we are in census.go.

I'm okay with handling this discrepancy in the census package for now, but if we think it's better to also address this in the core codebase, we can include a change in a subsequent pull request. @leszko, @pwilczynskiclearcode — let me know what you think!

@rickstaa
Copy link
Contributor

@pwilczynskiclearcode, @leszko we can also change pipeline string to pipelineTag string to make the behavoir more clear from outside the census package.

@leszko
Copy link
Contributor

leszko commented Oct 22, 2024

Added one commit 421aa2c

I think I like the suggestion from @rickstaa to have this conversion outside the census code. We should use pipeline naming consistently through the code.

@pwilczynskiclearcode If you like my change, feel free to merge (after all CI builds pass).

@leszko leszko mentioned this pull request Oct 22, 2024
5 tasks
@pwilczynskiclearcode pwilczynskiclearcode merged commit 5d3bfec into ai-video Oct 22, 2024
14 checks passed
@pwilczynskiclearcode pwilczynskiclearcode deleted the 3185-unify-pipeline-tag branch October 22, 2024 13:16
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 36.07820%. Comparing base (e94b188) to head (c41f3c4).
Report is 10 commits behind head on ai-video.

Files with missing lines Patch % Lines
server/ai_process.go 0.00000% 9 Missing ⚠️
monitor/census.go 0.00000% 8 Missing ⚠️
cmd/livepeer/starter/starter.go 0.00000% 1 Missing ⚠️
server/handlers.go 0.00000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                  @@
##            ai-video       #3191          +/-   ##
====================================================
- Coverage   50.82671%   36.07820%   -14.74851%     
====================================================
  Files            100         124          +24     
  Lines          23769       34525       +10756     
====================================================
+ Hits           12081       12456         +375     
- Misses         11018       21381       +10363     
- Partials         670         688          +18     
Files with missing lines Coverage Δ
cmd/livepeer/starter/starter.go 7.75695% <0.00000%> (-0.03020%) ⬇️
server/handlers.go 53.97083% <0.00000%> (ø)
monitor/census.go 61.69786% <0.00000%> (+0.12348%) ⬆️
server/ai_process.go 0.00000% <0.00000%> (ø)

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3fd912...c41f3c4. Read the comment docs.

Files with missing lines Coverage Δ
cmd/livepeer/starter/starter.go 7.75695% <0.00000%> (-0.03020%) ⬇️
server/handlers.go 53.97083% <0.00000%> (ø)
monitor/census.go 61.69786% <0.00000%> (+0.12348%) ⬆️
server/ai_process.go 0.00000% <0.00000%> (ø)

... and 25 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ai_ prometheus metrics produced with inconsistent pipeline tag
3 participants