Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new orchestrator capacities metric #3205

Closed
wants to merge 2 commits into from
Closed

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Oct 14, 2024

What does this pull request do? Explain your changes. (required)

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 57.38314%. Comparing base (aad1a23) to head (8b251c8).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
server/broadcast.go 0.00000% 8 Missing ⚠️
monitor/census.go 69.23077% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3205         +/-   ##
===================================================
- Coverage   57.40145%   57.38314%   -0.01831%     
===================================================
  Files             92          92                 
  Lines          15855       15874         +19     
===================================================
+ Hits            9101        9109          +8     
- Misses          6147        6157         +10     
- Partials         607         608          +1     
Files with missing lines Coverage Δ
monitor/census.go 66.29834% <69.23077%> (+0.00411%) ⬆️
server/broadcast.go 79.38689% <0.00000%> (-0.59181%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad1a23...8b251c8. Read the comment docs.

Files with missing lines Coverage Δ
monitor/census.go 66.29834% <69.23077%> (+0.00411%) ⬆️
server/broadcast.go 79.38689% <0.00000%> (-0.59181%) ⬇️

@mjh1
Copy link
Contributor Author

mjh1 commented Oct 21, 2024

I'll reopen this once we have a way of surfacing the capacity info from the Os

@mjh1 mjh1 closed this Oct 21, 2024
@mjh1 mjh1 deleted the mh/capacity-metric branch October 21, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant