Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golang version to 1.23.2 #3213

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Bump golang version to 1.23.2 #3213

merged 2 commits into from
Oct 22, 2024

Conversation

j0sh
Copy link
Collaborator

@j0sh j0sh commented Oct 18, 2024

What does this pull request do? Explain your changes. (required)

Bump golang version to 1.23.2 from 1.21.4

This is needed for #3211 - technically only 1.22 is required but golang is already on 1.23 and releases are very stable so we might as well ... go ... straight to the latest version.

Specific updates (required)

  • Updates go.mod
  • Updates CI downloads

Technically we do not need to update the CI-installed version of golang because apparently go mod will download updated toolchains on its own (!) since version 1.21 but it seems better to stay somewhat consistent. This behavior also eases the migration path for fellow developers: if you could already compile go-livepeer before this, you can still compile go-livepeer after - this without doing anything - since your golang will automatically update itself (!)

How did you test each of these updates (required)

Everything compiles and tests pass

Does this pull request close any open issues?

Checklist:

@j0sh j0sh requested review from leszko and rickstaa October 18, 2024 23:06
@github-actions github-actions bot added the AI Issues and PR related to the AI-video branch. label Oct 18, 2024
@leszko
Copy link
Contributor

leszko commented Oct 21, 2024

@j0sh The PR looks fine, but please check if CI is passing. I just enabled CI with tests and lint, so let's try to keep it green.

Sorry if it broke your build, but I'm trying to put ai-video into good shape (and then merge it into master). Thanks for the understanding.

@j0sh
Copy link
Collaborator Author

j0sh commented Oct 21, 2024

@leszko Seems that CI passed (see image below), unless you are referring to something else?

image

@j0sh j0sh merged commit ff1f517 into ai-video Oct 22, 2024
14 checks passed
@j0sh j0sh deleted the ja/bump-golang-1-23-2 branch October 22, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants