Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ai): remove code redundancy in AI orchestrator server #3226

Open
wants to merge 1 commit into
base: ai-video
Choose a base branch
from

Conversation

rickstaa
Copy link
Contributor

@rickstaa rickstaa commented Oct 29, 2024

What does this pull request do? Explain your changes. (required)

This commit removes redundant code in the AI orchestrator server file
(i.e. ai_http.go) to increase code readability.

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Checklist:

@github-actions github-actions bot added the AI Issues and PR related to the AI-video branch. label Oct 29, 2024
@rickstaa rickstaa marked this pull request as draft October 29, 2024 13:53
This commit removes redundant code in the AI orchestrator server file
(i.e. `ai_http.go`) to increase code readability.
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 26.92308% with 19 lines in your changes missing coverage. Please review.

Project coverage is 36.05166%. Comparing base (c41f3c4) to head (5b16cb7).
Report is 9 commits behind head on ai-video.

Files with missing lines Patch % Lines
server/ai_http.go 0.00000% 11 Missing ⚠️
server/utils.go 0.00000% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##            ai-video       #3226         +/-   ##
===================================================
- Coverage   36.07820%   36.05166%   -0.02654%     
===================================================
  Files            124         125          +1     
  Lines          34525       34531          +6     
===================================================
- Hits           12456       12449          -7     
- Misses         21381       21394         +13     
  Partials         688         688                 
Files with missing lines Coverage Δ
server/ai_mediaserver.go 10.68702% <100.00000%> (+0.64985%) ⬆️
server/utils.go 0.00000% <0.00000%> (ø)
server/ai_http.go 13.21586% <0.00000%> (+2.14575%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d966f8...5b16cb7. Read the comment docs.

Files with missing lines Coverage Δ
server/ai_mediaserver.go 10.68702% <100.00000%> (+0.64985%) ⬆️
server/utils.go 0.00000% <0.00000%> (ø)
server/ai_http.go 13.21586% <0.00000%> (+2.14575%) ⬆️

... and 2 files with indirect coverage changes

@rickstaa rickstaa marked this pull request as ready for review October 29, 2024 15:35
@rickstaa rickstaa requested a review from leszko October 29, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants