Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ai/live: Handle more special cases in trickle. #3332

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

j0sh
Copy link
Collaborator

@j0sh j0sh commented Dec 20, 2024

ai/live: More error handling for gotrickle clients.

  • Handles additional stopping conditions in publisher such as 404
  • Handles "stream exists but segment doesn't" condition in subscriber

These lead to 1) more timely shutdowns when necessary, and 2) faster recovery if a subscription falls behind

ai/live: Close a segment if it will be dropped.

This is being polite to notify any subscribers that might be
waiting for the segment that the segment will not be around.

Not required if the segment is written normally, and subscribers
will still work fine without; it would just take longer to happen
when the segment drops out of the window of active segments.

j0sh added 2 commits December 20, 2024 06:37
Handles additional stopping conditions in publisher such as 404

Handles "stream exists but segment doesn't" condition in subscriber
This is being polite to notify any subscribers that might be
waiting for the segment that the segment will not be around.

Not required if the segment is written normally, and subscribers
will still work fine without; it would just take longer to happen
when the segment drops out of the window of active segments.
@j0sh j0sh requested review from victorges, leszko and mjh1 December 20, 2024 06:42
@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Dec 20, 2024
trickle/trickle_publisher.go Dismissed Show dismissed Hide dismissed
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 98 lines in your changes missing coverage. Please review.

Project coverage is 33.75274%. Comparing base (2ff0054) to head (09a77a2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
trickle/trickle_server.go 0.00000% 38 Missing ⚠️
trickle/trickle_subscriber.go 0.00000% 27 Missing ⚠️
trickle/trickle_publisher.go 0.00000% 20 Missing ⚠️
server/ai_live_video.go 0.00000% 13 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3332         +/-   ##
===================================================
- Coverage   33.83786%   33.75274%   -0.08512%     
===================================================
  Files            141         141                 
  Lines          37263       37354         +91     
===================================================
- Hits           12609       12608          -1     
- Misses         23934       24026         +92     
  Partials         720         720                 
Files with missing lines Coverage Δ
server/ai_live_video.go 0.00000% <0.00000%> (ø)
trickle/trickle_publisher.go 0.00000% <0.00000%> (ø)
trickle/trickle_subscriber.go 0.00000% <0.00000%> (ø)
trickle/trickle_server.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ff0054...09a77a2. Read the comment docs.

Files with missing lines Coverage Δ
server/ai_live_video.go 0.00000% <0.00000%> (ø)
trickle/trickle_publisher.go 0.00000% <0.00000%> (ø)
trickle/trickle_subscriber.go 0.00000% <0.00000%> (ø)
trickle/trickle_server.go 0.00000% <0.00000%> (ø)

... and 1 file with indirect coverage changes

@j0sh j0sh merged commit 0bfd28b into master Dec 20, 2024
16 checks passed
@j0sh j0sh deleted the ja/more-trickle-exceptions branch December 20, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Issues and PR related to the AI-video branch. go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants