Failing tests for keyword list -> tuple conversion #1486
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NduatiK this is necessary for the stylesheet Elixir map to json conversion task.
Some background, we were previously parsing named arguments into a single keyword list. However, in SwiftUI named arguments are individual arguments not a combination of a few into a single argument. For example this modifiers:
has arity of 4 but our parser actually converts this into arity of 3:
Instead we want to represent named arguments are tuple pairs:
I've updated the tests to reflect this change and just need the parser updated.