-
-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] stringify
/parse
: add encodeDotKeys
/decodeDotKeys
respectively to allow . in object keys
#488
Conversation
@ljharb I wonder if we need |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 9 9
Lines 1600 1645 +45
Branches 187 190 +3
=======================================
+ Hits 1597 1642 +45
Misses 3 3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test cases that use encodeValuesOnly with this option.
14a0bcd
to
0b83865
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good; I can clean up the remaining comments.
@ljharb I realised that |
867fc7b
to
d514cc9
Compare
d514cc9
to
882bee2
Compare
7231cb8
to
30004b2
Compare
Previously the dot in the keys would be encoded but the round-tripping was broken. Here is the previous behavior
This PR fixes the above behavior and fixes #249: