Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move alias check before custom handler check #1515

Closed
wants to merge 3 commits into from
Closed

Move alias check before custom handler check #1515

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 19, 2024

Move alias check before custom handler check.

Checklist

Related issues

Closes #1514

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Merging #1515 (e8186c6) into master (c87af6d) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1515      +/-   ##
==========================================
- Coverage   57.08%   57.04%   -0.05%     
==========================================
  Files          60       60              
  Lines        2123     2123              
==========================================
- Hits         1212     1211       -1     
- Misses        911      912       +1     

@ghost
Copy link
Author

ghost commented Mar 21, 2024

Hmm.. do you have any guidance on why the coverage results changed?
When running coverage locally, I don't see any change.

@lk-geimfari
Copy link
Owner

Hmm.. do you have any guidance on why the coverage results changed?

When running coverage locally, I don't see any change.

See #1489

@ghost ghost closed this Apr 25, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

A custom handler with an alias returns an error when using the alias
1 participant