-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Bitcoin Transaction Signing with AWS KMS and scure-btc-signer #134
Open
devin-ai-integration
wants to merge
34
commits into
master
Choose a base branch
from
devin/bitcoin-signing-feature/6134
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and documentation
dosubot
bot
added
the
size:L
This PR changes 100-499 lines, ignoring generated files.
label
Jun 8, 2024
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
and removed
size:L
This PR changes 100-499 lines, ignoring generated files.
labels
Jun 8, 2024
…y in sendTransactionTestnet.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Bitcoin Transaction Signing with AWS KMS and scure-btc-signer in Llavero Repository
Description
This pull request implements a system for signing Bitcoin transactions using AWS Key Management Service (KMS) and the scure-btc-signer library within the Llavero repository. The implementation focuses on secure key management, transaction hashing, signing, construction, and verification, with comprehensive documentation and testing.
Changes
Project Setup:
Key Management:
Transaction Hashing:
Signing:
Transaction Construction:
Verification:
Error Handling:
Documentation and Testing:
Checklist
Notes