Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop Service B: Implement configureSubdomain Function #138

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Pull Request: Develop Service B - Implement configureSubdomain Function

Summary of Changes

  • Developed Service B (apps/domain-requester) to handle the configuration of subdomains in AWS using the parameters provided by Service A.
  • Implemented the configureSubdomain function in domainRequester.ts to create DNS records for the subdomain in Route 53 and set up a CloudFront distribution if required.
  • The function returns an object containing the subdomain name, distribution ID, and distribution domain name upon successful configuration.
  • Addressed linting errors and ensured compliance with ESLint rules.

Link to Devin Run

Devin Run

User Request

This PR was requested by the user to develop Service B as part of the Llavero Wallet application. The user story involves configuring the main domain in AWS using CloudFront and Route 53 and determining parameters for subdomain configuration.

Checklist

  • Implemented the configureSubdomain function in domainRequester.ts.
  • Created DNS records for the subdomain in Route 53.
  • Set up a CloudFront distribution for the subdomain if required.
  • Ensured the function returns the correct subdomain details.
  • Addressed linting errors and ensured compliance with ESLint rules.
  • Compiled the code successfully.
  • Tested the web app on the local environment.

Notes

  • The credentials for integration testing are stored in Secrets.
  • The documentation and research findings are written in markdown and added to the docs/domain-manager folder.
  • Best practices for setting up and managing domains and subdomains in AWS are documented, including potential pitfalls and recommendations for optimal performance and security.

Footer

This PR was written by Devin-AI. This Devin run was requested by Mariano.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants