-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile updates and Fixes to CI process #17
Dockerfile updates and Fixes to CI process #17
Conversation
I think what's happening is that some of your dependencies are made to work with glibc, and in Alpine they have to be recompiled. The base image should be |
The last 2 major releases of Node with Debian only support arm/v8 and arm/v7, arm/v6 was deprecated several years ago. |
Using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still need the COPY and EXPOSE commands:
COPY . .
EXPOSE 8000
@lllllllillllllillll They still there, the diff doesn't show them. See file here: https://github.com/gaby/DweebUI/blob/docker-fixes/Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@lllllllillllllillll You have to enable |
@lllllllillllllillll Go here https://github.com/lllllllillllllillll/DweebUI/settings/actions at the bottom change the workflow permissions to this: Then re-run the failed workflow from here: https://github.com/lllllllillllllillll/DweebUI/actions/runs/6922322719 and it should publish the image as: |
Success! |
@lllllllillllllillll On the packages page, on the right side it says "Package Setting". Allow public to see them, by default they are hidden. |
You should see the newest built package now. |
I do! Awesome! 💪💪💪 |
I think I need to enable dependabot alerts as well now. |
Yes, they are disable by default. Haha 😂 you will get quite a few PR's few minutes after enabling them |
I've enabled dependabot alerts, but I'm not sure how to confirm it's using the |
@lllllllillllllillll Give it like 10mins, all you need to do is click "enable" in the dependabot section of the project settings |
Under https://github.com/lllllllillllllillll/DweebUI/settings/security_analysis Enable the 3 options that say "Dependabot" |
Yep, enabled. |
20-alpine
, the20.0.0-alpine
hasn't been updated in 8 months.dependabot
to track updatestarget: release
from CI file. This is a carry-over from my re-using my CI files@lllllllillllllillll This PR fixes the CI issues introduced in #16