Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADT][NFCI]: Fix iterator category for graph iterators with external … #116403

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Nov 15, 2024

  1. [ADT][NFCI]: Fix iterator category for graph iterators with external …

    …storage
    
    Set the iterator category for graph iterators to input_iterator_tag when
    the visited set is stored externally. In that case we can't provide
    multi-pass guarantee, so we should not claim to be a forward iterator.
    
    Fixes: llvm#116400
    Maetveis committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    468b66a View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. [ADT][Test]: multi-Pass safety, iterator_category for graph iterators

    Check that using the same iterators for multiple passes produces the
    same result, as required by the C++ standard for forward iterators.
    
    Add a static_asserts for the iterator_category of Graph iterators
    (BreadthFirstIterator, DepthFirstIterator, PostOrderIterator).
    Maetveis committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    b591615 View commit details
    Browse the repository at this point in the history