Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifying the coordinate transformation function #30

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Simplifying the coordinate transformation function #30

merged 2 commits into from
Jul 28, 2023

Conversation

lmalina
Copy link
Owner

@lmalina lmalina commented Jul 27, 2023

Now it takes an element as an input and returns it with update T1, T2, R1, and R2 attributes.
Removed option of reference point in centre as everything (misalignments, etc.) is now relative to the entrance

@lmalina lmalina requested a review from bi-veglia July 27, 2023 11:05
bi-veglia
bi-veglia approved these changes Jul 27, 2023
View reviewed changes
Copy link
Collaborator

@bi-veglia bi-veglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look and played around, all looks fine and definitely looks better than before

@lmalina lmalina merged commit 76ac73e into master Jul 28, 2023
18 checks passed
@lmalina lmalina deleted the coordinate_transformation branch July 28, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bi-veglia bi-veglia bi-veglia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmalina @bi-veglia