Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loco #50

Merged
merged 34 commits into from
Jan 22, 2024
Merged

Loco #50

merged 34 commits into from
Jan 22, 2024

Conversation

elafmusa
Copy link
Collaborator

No description provided.

@elafmusa
Add files via upload
06cfb3c 
Preliminary test for loco including bpm and correctors calibration as fit parameters
@elafmusa
Add files via upload
3298e31 
loco modules
@elafmusa elafmusa requested a review from lmalina October 20, 2023 16:16
elafmusa and others added 27 commits October 27, 2023 11:28
Updated loco modules
758101b
Updated loco modules
7acfcf6
@elafmusa
Delete pySC/example_ng.py
41a5fa5
@elafmusa
Delete pySC/example_lm.py
29532e5
Updated loco modules
43fcab0
Merge remote-tracking branch 'origin/loco' into loco
02efa98
@elafmusa
Updated loco modules
1d3683e
@elafmusa
Update loco_modules.py
e1f8804
@elafmusa
Delete pySC/Fcc_skew_example directory
936ca49
@elafmusa
Delete pySC/example_lm_testBeta.ipynb
837995a
@elafmusa
Add files via upload
cdb6cab 
Usage example
@elafmusa
Add files via upload
1335a5a
@elafmusa
Delete pySC/example_lm.ipynb
763a539
@elafmusa
Delete pySC/example.ipynb
129e076
@elafmusa
Update loco_modules.py
5e13bbc
@lmalina
Fixing imports and simplification of the code
21656dd
@lmalina
Simplification of the code
7798057
@lmalina
Making iterations work + little refactoring
4451238
@lmalina
Many options did not work - further fixing and refactoring
31f3280 
    refactored a bit jacobian calculation
        no dispersion in measured ORM
    split and simplified LOCO correction method
        'lm' method (least square) converges, 'ng' does not
        TODO refactor 'ng' is similar to objective method
@lmalina
Explicit plotting and simplified matrix inversion
f7dd7aa
@lmalina
Refactoring: LOCO correction method 'ng' now uses objective function
464649e 
    TODO still does not work
@lmalina
Forgotten couple of lines
516911a
@elafmusa
Delete pySC/example_hmba.ipynb
70d8bdc 
Delete notebook
@elafmusa
Delete pySC/PETRAIII directory
f3283b6 
Delete P3 example
@elafmusa
Speed up calculations in get_inverse function
12a3770
@lmalina
Speedup of objective function (~ factor 10)
fd1fc10
@lmalina
Refactoring of objective function
813d0b2
elafmusa and others added 2 commits January 15, 2024 09:24
ng function and other small modifications
94aaa5f
@lmalina
Calculation of full Jacobian and removed transpositions on "user side"
5209961 
    included BPM and corrector scalings
    code cleanup
    Some transposition which may not be necesary remain inside the code
@elafmusa elafmusa marked this pull request as ready for review January 22, 2024 12:13
lmalina
lmalina previously approved these changes Jan 22, 2024
View reviewed changes
Copy link
Owner

@lmalina lmalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to have a first working version! Few things should be fixed in further development.

lmalina
lmalina approved these changes Jan 22, 2024
View reviewed changes
Copy link
Owner

@lmalina lmalina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to have a first working version! Few things should be fixed in further development.

@lmalina lmalina merged commit 6bd2d5f into master Jan 22, 2024
18 checks passed
@lmalina lmalina deleted the loco branch January 24, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmalina lmalina lmalina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elafmusa @lmalina