Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NameError handling in expression code #130

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

shazarivf
Copy link
Contributor

Fixes #129

@newville could you take a look please?

Copy link

codecov bot commented Jul 27, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@newville newville merged commit 1dec732 into lmfit:master Jul 27, 2024
17 checks passed
@newville
Copy link
Member

@shazarivf Thanks! Looking at this some more, I might add a few more changes in the error handling too.

@shazarivf shazarivf deleted the fix-nameerror-handling branch July 29, 2024 08:39
@shazarivf
Copy link
Contributor Author

@newville Thanks! Can a release be made with this fix anytime soon?

@shazarivf
Copy link
Contributor Author

@newville could you tell me when a release can be made with this change? It's a blocker for us.

@newville
Copy link
Member

newville commented Aug 2, 2024

@shazarivf 1.0.2 has been tagged and pushed to PyPI. I don't usually consider each bug fix to require a release. FWIW, asking for a release of open-source software twice in two days is probably not going to be a winning strategy very often.

@shazarivf
Copy link
Contributor Author

@newville thanks for making an exception. Yeah I get it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling NameError is not working
2 participants