updated all tests, captured warnings #174

localdevices · Sep 20, 2024 · 46226c5 · 46226c5
1 parent 2e70beb
commit 46226c5
Show file tree

Hide file tree

Showing 11 changed files with 38 additions and 367 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -14,7 +14,7 @@ on:
       - tests/*
       - pyorc/*
       - pyproject.toml
-jobs:  
+jobs:
   Test-matrix:
     name: ${{ matrix.os }} - py${{ matrix.python-version }}
     runs-on: ${{ matrix.os }}
@@ -26,7 +26,7 @@ jobs:
       matrix:
         os: ["ubuntu-latest" ] #, "macos-latest", "windows-latest"]
         python-version: ["3.10"] # fix tests to support older versions
-    
+
     steps:
       - uses: actions/checkout@v4
 
@@ -54,5 +54,8 @@ jobs:
       # run all tests
       - name: Test
         run: python -m pytest --verbose --cov=pyorc --cov-report xml
-
-      - uses: codecov/codecov-action@v4
+
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@v4
+        env:
+          CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
diff --git a/examples/04_Extracting_crosssection_velocities_and_discharge.ipynb b/examples/04_Extracting_crosssection_velocities_and_discharge.ipynb
diff --git a/pyorc/api/cameraconfig.py b/pyorc/api/cameraconfig.py
@@ -663,8 +663,6 @@ def get_M(
         z_a = self.get_z_a(h_a)
         z_a -= self.gcps_mean[-1]
         # treating 3D homography
-        print(dst_a)
-        # print(z_a)
         return cv.get_M_3D(
             src=src,
             dst=dst_a,

diff --git a/pyorc/api/video.py b/pyorc/api/video.py
@@ -43,7 +43,7 @@ def __init__(
             end_frame: Optional[int] = None,
             freq: Optional[int] = 1,
             stabilize: Optional[List[List]] = None,
-            lazy: bool = True,
+            lazy: bool = False,
             rotation: Optional[int] = None,
             fps: Optional[float] = None,
     ):
@@ -87,11 +87,6 @@ def __init__(
         self.feats_errs = None
         self.ms = None
         self.mask = None
-        if lazy:
-            warnings.warn(
-                "`lazy=False` will become the default in v0.6.0. If you set `lazy=False explicitly, this warning will "
-                "be suppressed"
-            )
         self.lazy = lazy
         self.stabilize = stabilize
         if camera_config is not None:

diff --git a/pyorc/cli/cli_elements.py b/pyorc/cli/cli_elements.py
@@ -480,7 +480,7 @@ def __init__(self, img, logger=logging):
             size=12,
             path_effects=path_effects
         )
-        self.ax.legend()
+        # self.ax.legend()
         # add dst coords in the intended CRS
         self.required_clicks = 4  # minimum 4 points needed for a satisfactory ROI