Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix aws-replicator compatibility with localstack >=3.4 #63

Merged
merged 2 commits into from
Jun 5, 2024
Merged

fix aws-replicator compatibility with localstack >=3.4 #63

merged 2 commits into from
Jun 5, 2024

Conversation

thrau
Copy link
Member

@thrau thrau commented Jun 5, 2024

While working on #62 I noticed a couple of things weren't working with the aws-replicator in combination with LS 3.4+.

  • We've moved the TEST_* variables into localstack.testing.config
  • It seems the replicator proxy currently doesn't work with twisted as gateway

@thrau thrau requested a review from whummer as a code owner June 5, 2024 14:07
@thrau thrau requested a review from alexrashed June 5, 2024 14:11
alexrashed
alexrashed approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the extension / upgrading it to the latest version! 🚀 🦸🏽

@thrau thrau merged commit 0cab1aa into main Jun 5, 2024
1 check passed
@whummer whummer deleted the update-replicator-extension branch June 5, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexrashed alexrashed alexrashed approved these changes

@whummer whummer Awaiting requested review from whummer whummer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thrau @alexrashed