Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix package conflict by moving localstack dep to dev extra #73

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

alexrashed
Copy link
Member

Motivation

With localstack/localstack#11190, the localstack module is now an implicit namespace module.
However, in the latest release (3.5) this was not yet the case.
This uncovered an issue with the extensions if they define localstack-core (either directly or transitively via localstack-core) as an install-dependency:

  • When installing the extension, the python package install dependencies are also installed into the extension virtual environment.
  • When the extension defines an install-dependency on localstack-core, it will install the latest release of localstack-core into the extension virtual environment.
    • The extension virtual environment is directly linked to the main virtual environment in the LocalStack container and should directly use the code from the image (and not install it as an additional external dependency).
    • However, this currently causes a conflict because the installed version 3.5 - since it's not an implicit namespace package yet - which overwrites the module in the main venv.

@alexrashed alexrashed self-assigned this Jul 16, 2024
@alexrashed
Copy link
Member Author

@HarshCasper @whummer: The CI for the miniflare extension is failing, but it seems to me as this is not related to the namespace package or this fix.

@alexrashed alexrashed marked this pull request as ready for review July 16, 2024 07:18
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for addressing these, should now avoid the clash between the localstack packages in the python path 🥳

@alexrashed alexrashed merged commit 97ad22a into main Jul 16, 2024
1 of 2 checks passed
@alexrashed alexrashed deleted the fix-extensions-after-localstack-namespace-package branch July 16, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants