isInCircleAdapt sketch Java port #311
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do the non-robust calculation and calculation of error margin. If calculation is possibly not robust, fall back on slower math. https://www.cs.cmu.edu/afs/cs/project/quake/public/code/predicates.c
dr-jts
reviewed
Sep 4, 2018
| if (-det > errbound)) { | ||
| return false; | ||
| } | ||
| return isInCircleDDSlow(a, b, c, p); |
There was a problem hiding this comment.
Should call inCircleDDFast - it is equivalent and faster
|
Need unit tests before rolling this in. |
|
Good find. This should provide both performance and robustness. The same approach is currently used in computing the orientationIndex. Also based on Shewchuk's fine work. |
|
Just in case, I would be happy if someone familiar with java takes over this PR, to make proper formatting, unit tests and code style. |
|
Makes sense. And add some unit tests. Not sure when I'll have time to work on this though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the non-robust calculation and calculation of error margin. If calculation is possibly not robust, fall back on slower math.
https://www.cs.cmu.edu/afs/cs/project/quake/public/code/predicates.c
References #298