Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ phpstan level 2 #393

Merged
merged 1 commit into from
Jul 18, 2023
Merged

✨ phpstan level 2 #393

merged 1 commit into from
Jul 18, 2023

Conversation

Kanti
Copy link
Contributor

@Kanti Kanti commented Jul 18, 2023

Short description

...

Related Issue

...

More Details

  • Work in Progress?
  • Open Issues?

@lochmueller
Copy link
Owner

Hey @Kanti ,
thanks for the cleanup. Merged... next time please avoid assert and use return/Exception.
https://www.php.net/manual/en/function.assert.php ("assertions that take effect in development and testing environments, but are optimised away to have zero cost in production.")
Regards,
Tim

@lochmueller lochmueller merged commit 3844cbc into lochmueller:master Jul 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kanti @lochmueller