createdAt, updatedAt for brand #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loevgaard
requested changes
Dec 19, 2019
| /** | ||
| * @return \DateTime | ||
| */ | ||
| public function getCreatedAt(): \DateTime; |
There was a problem hiding this comment.
We can't change the interface without releasing a new major, so instead add these method as phpdoc method on the interface. Then we will add them to the actual interface in v3
| /** | ||
| * @return \DateTime | ||
| */ | ||
| public function getCreatedAt(): \DateTime |
There was a problem hiding this comment.
Use the Sylius\Component\Resource\Model\TimestampableTrait instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following our conversation here: #61
Since it's only for DB - It's lacking tests and no UI, but I did add couple getters.
Feel free to correct PR if there are any mistakes.