Feature/fix builds docker syntax #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalbreuninger
approved these changes
Dec 19, 2024
bkneis
force-pushed
the
feature/fix-builds-docker-syntax
branch
from
02cd1f7 to
2bcb5c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1481
In summary devpod always assumes a build syntax of docker/dockerfile:1.4. The reference CLI parses out the build syntax and uses it in the feature layers - https://github.com/devcontainers/cli/blob/main/src/spec-node/containerFeatures.ts#L200
This PR does the same falling back to 1.4 if no build syntax is specified.
I tested this using examples/build and adding the problematic build commands such as
RUN --checksumand watching it fail then work with the PR