Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENG-834 Add fetching autofeedback by completion id to cli #175

Merged
merged 4 commits into from
Jun 4, 2024
Merged

ENG-834 Add fetching autofeedback by completion id to cli #175

merged 4 commits into from
Jun 4, 2024

Conversation

kxtran
Copy link
Collaborator

@kxtran kxtran commented Jun 3, 2024 •
edited
Loading

Description:

log10 feedback --help
Usage: log10 feedback [OPTIONS] COMMAND [ARGS]...

  Manage feedback for completions i.e. capturing feedback from users

Options:
  --help  Show this message and exit.

Commands:
  autofeedback  Manage auto feedback for completions i.e.
  create        Add feedback to a group of completions associated with a...
  download      Download feedback based on the provided criteria.
  get           Get feedback based on provided ID.
  list          List feedback based on the provided criteria.
  predict       Generate feedback with existing feedback

log10 feedback autofeedback --help
Usage: log10 feedback autofeedback [OPTIONS] COMMAND [ARGS]...

  Manage auto feedback for completions i.e. capturing feedback from users

Options:
  --help  Show this message and exit.

Commands:
  get  Get an auto feedback by completion id

log10 feedback autofeedback get --help
Usage: log10 feedback autofeedback get [OPTIONS]

  Get an auto feedback by completion id

Options:
  --completion-id TEXT  Completion ID  [required]

@kxtran kxtran requested review from wenzhe-log10 and nqn June 3, 2024 16:34
@kxtran kxtran changed the title Add fetching autofeedback by completion id to cli ENG-834 Add fetching autofeedback by completion id to cli Jun 3, 2024
wenzhe-log10
wenzhe-log10 reviewed Jun 3, 2024
View reviewed changes
log10/__main__.py Outdated Show resolved Hide resolved
@kxtran kxtran requested a review from wenzhe-log10 June 4, 2024 04:39
wenzhe-log10
wenzhe-log10 approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@wenzhe-log10 wenzhe-log10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some comments on doc update and function naming.

cli_docs.md Outdated Show resolved Hide resolved
log10/feedback/autofeedback.py

@click.command()
@click.option("--completion-id", required=True, help="Completion ID")
def get_autofeedback_cli(completion_id: str):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about name it get_autofeedback? not sure we want the cli in the function name.

Copy link
Collaborator Author

@kxtran kxtran Jun 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the sdk called get_autofeedback so I was trying to differentiate between this one and sdk since they both have the same argument as well. I'm open for any naming suggestion that could be either this one or the actual cli func

log10/feedback/autofeedback.py Outdated Show resolved Hide resolved
log10/_httpx_utils.py Show resolved Hide resolved
@kxtran kxtran merged commit 59a22e5 into main Jun 4, 2024
2 checks passed
@kxtran kxtran deleted the kt/add-af-cli branch June 4, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzhe-log10 wenzhe-log10 wenzhe-log10 approved these changes

@nqn nqn Awaiting requested review from nqn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kxtran @wenzhe-log10