ENG-849 ENG-819 Refactor Anthropic parsing code for async and sync with httpx client #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxtran
changed the title
kxtran
commented
Jun 11, 2024
kxtran
commented
Jun 11, 2024
kxtran
commented
Jun 11, 2024
kxtran
commented
Jun 11, 2024
kxtran
commented
Jun 11, 2024
kxtran
commented
Jun 11, 2024
kxtran
commented
Jun 11, 2024
kxtran
commented
Jun 11, 2024
kxtran
force-pushed
the
kt/update-anthropic-funcion-calls
branch
from
72a249f
to
1cb5bc0
Compare
kxtran
force-pushed
the
kt/update-anthropic-funcion-calls
branch
from
1cb5bc0
to
d190b96
Compare
Comment on lines
-12
to
+9
| from log10.load import log10 | ||
| from log10.load import Anthropic, AsyncAnthropic |
There was a problem hiding this comment.
wondering if we should keep testing log10(anthropic) assume that's the main use case. Then add separate from log10.load import Anthropic, AsyncAnthropic tests (could be in a follow up PR).
There was a problem hiding this comment.
we use log10(anthropic) in test_magentic.py, would that be enough coverage?
tests/test_magentic.py
Outdated
|
|
||
|
|
||
| @pytest.fixture | ||
| def _fixt(llm_provider, magentic_models, request): |
There was a problem hiding this comment.
maybe rename chat_model?
There was a problem hiding this comment.
I updated to _magentic_model_obj, is it okay?
|
anthropic released 0.29.0 today. should we check if 0.29 works in this PR? |
I updated anthropic version to 0.29.0 and some of examples with the latest model. They all work as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
0.29.0version