Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENG-850] Large files break logger #184

Merged
merged 5 commits into from
Jun 11, 2024
Merged

[ENG-850] Large files break logger #184

merged 5 commits into from
Jun 11, 2024

Conversation

nqn
Copy link
Contributor

@nqn nqn commented Jun 11, 2024

When the request fails in async mode, we cannot write the response either (completion id being None)

kxtran
kxtran approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@kxtran kxtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would you mind to add a unit test for it? I also could follow up for it

@nqn nqn changed the title Large files break logger [ENG-850] Large files break logger Jun 11, 2024
@nqn nqn merged commit 2912d54 into main Jun 11, 2024
1 of 2 checks passed
@nqn nqn deleted the nqn/large-files branch June 11, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kxtran kxtran kxtran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nqn @kxtran