ENG-879 ENG-882 Move cli logic into its own folder #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxtran
changed the title
kxtran
changed the title
log10/completions/completions.py
Outdated
Comment on lines
101
to
105
| if not response: | ||
| tool_calls = first_choice["message"].get("tool_calls", []) | ||
| if tool_calls: | ||
| last_tool_call = tool_calls[-1] | ||
| response = last_tool_call.get("function", {}).get("arguments", "") |
There was a problem hiding this comment.
could we simplify the ifs within if "message" in first_choice?
There was a problem hiding this comment.
Updated. Does it look better?
There was a problem hiding this comment.
I found function _render_completions_table is used for cli. so could be moved to cli/completions.py. Then we could remove the import rich, pandas, etc. in log10/completions/completions.py.
There was a problem hiding this comment.
I also moved _render_comparison_table and _create_dataframe_from_comparison_data function because they also use rich and pandas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When accessing the Feedback, FeedbackTask, or Autofeedback objects in the SDK, users currently need to install CLI-related modules due to the existing code structure. To streamline this and keep the package lightweight, we can move the CLI code logic into its own folder.
pyproject.tomlto make it easy to install the modules