Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize perplexity logic for streaming end detection across OpenAI compatible models #286

Merged
merged 11 commits into from
Aug 29, 2024

Conversation

kxtran
Copy link
Collaborator

@kxtran kxtran commented Aug 26, 2024

No description provided.


return {
"base_url": request.param["base_url"],
"api_key": request.param["api_key"],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I avoided using os.environ.get(request.param["api_key"]) in the fixture. When a test is failed and the api key is loaded in the fixture, the pytest report will print out the api keys.

Copy link
Collaborator

@wenzhe-log10 wenzhe-log10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kxtran kxtran merged commit 98dbb2c into main Aug 29, 2024
3 checks passed
@kxtran kxtran deleted the kt/cerebras-async-stream branch August 29, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants