HTTPX client #93
HTTPX client #93
Conversation
log10/load.py
Outdated
| if target_service == "bigquery": | ||
| return str(uuid.uuid4()) | ||
|
|
||
| def post_request(url: str, json: dict = {}) -> requests.Response: |
There was a problem hiding this comment.
| def post_request(url: str, json: dict = {}) -> requests.Response: | |
| def post_request(url: str, json: dict = {}) -> httpx.Response: |
also remove the import requests
log10/load.py
Outdated
| if target_service == "bigquery": | ||
| return str(uuid.uuid4()) | ||
|
|
||
| def post_request(url: str, json: dict = {}) -> requests.Response: |
There was a problem hiding this comment.
Since this swallows exceptions, should we rename to try_post_request?
log10/load.py
Outdated
| # | ||
| # Store request | ||
| # | ||
| post_request(url, json=log_row) |
There was a problem hiding this comment.
Maybe post request should get moved out of the try/except since it already absorbs exceptions. That way the try/except can tightly wrap the LLM call.
| output = None | ||
| result_queue = queue.Queue() | ||
| global last_completion_response | ||
| global sessionID |
There was a problem hiding this comment.
Do these need to be global? We can address in a follow up PR.
log10/load.py
Outdated
| """ | ||
| Get session ID from log10. | ||
| """ | ||
| res = post_request(url + "/api/sessions", {}) |
There was a problem hiding this comment.
Since post_request swallows errors, we need to always check for None response eg if not res return None
log10/load.py
Outdated
| # If we cannot get a completion id, continue with degraded functionality (no logging). | ||
| # | ||
| completion_url = url + "/api/completions" | ||
| r = post_request(completion_url, json={}) |
There was a problem hiding this comment.
maybe it's worth to have a function to check response for all the post_request calls? We need to check if response is returned here to make sure that we can access the body.
No description provided.