Patch post request sites #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nqn
commented
Jan 30, 2024
| if target_service == "log10": | ||
| try: | ||
| res = post_request(completion_url + "/" + completionID, log_row) | ||
| except Exception as e: |
There was a problem hiding this comment.
May not need this nested exception handler - caught on line 228
There was a problem hiding this comment.
yea I think that we can remove try/catch here
kxtran
reviewed
Jan 30, 2024
Comment on lines
+110
to
113
| logging.warn( | ||
| "Failed anthorization. Please verify that LOG10_TOKEN and LOG10_ORG_ID are set correctly and try again." | ||
| + "\nSee https://github.com/log10-io/log10#%EF%B8%8F-setup for details" | ||
| ) |
There was a problem hiding this comment.
I was checking our api endpoint when we returns 401 and it should be okay to raise here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.