Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1533] Importing hopsworks fails due to core dump while importing polars #1379

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

manu-sj
Copy link
Contributor

@manu-sj manu-sj commented Sep 5, 2024

This PR fixes an issue in which hopworks is not importable because Polars throws a "" due to AVX instructions being unavailable.

pola-rs/polars#2922
https://github.com/pola-rs/polars?tab=readme-ov-file#legacy

Fix Done:
Make polars a optional dependency. The changes being done closely resembles the changes done for 4.0 (#1363)

JIRA Issue: https://hopsworks.atlassian.net/browse/FSTORE-1533

Related PRs:
logicalclocks/hopsworks-api#318
https://github.com/logicalclocks/loadtest/pull/454

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@manu-sj manu-sj requested a review from aversey September 6, 2024 12:30
@manu-sj manu-sj changed the title [FSTORE-1533] Importing hopsworks due to failing to import Polars [FSTORE-1533] Importing hopsworks fails due to core dump while importing polars Sep 6, 2024
@SirOibaf SirOibaf merged commit e18d967 into logicalclocks:branch-3.8 Sep 6, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants