[FSTORE-1281] Add method to stop execution + type hinting login+get_feature_store #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…store + stop execution method
robzor92
requested changes
May 7, 2024
There was a problem hiding this comment.
Looks good, but need to fix linter.
Also if we could add another test here with a workflow where the execution gets stopped would be great: https://github.com/logicalclocks/loadtest/blob/main/tests/workflows/hopsworks/test_job_execution.py
robzor92
requested changes
May 7, 2024
robzor92
requested changes
May 8, 2024
Co-authored-by: Robin Andersson <robin.eric.andersson@gmail.com>
robzor92
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…store + stop execution method