-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSTORE-1446] Merge GitHub Actions #214
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eate (#1071) * init * fix tests
* add serving key to fv * remove redundant variable * address comment
* added snowflake flyingduck support * small fixes * restructured query object * formatting * fixed filter column name for pushdown * provide default argument for fg_aliases * add connectors to test * added tests for snowflake connector * added strip_featurestore_name to util * print regular error message if external fg not supported by fd * addressed comments * removed printline
Co-authored-by: Fabio Buso <buso.fabio@gmail.com>
…… (#1080) * [FSTORE-963] feature group expectation_suite setter doesn't handle properly ExpectationSuite type objects * Update asserts
…for path connectors (#1070)
… (#1086) * added afs create train data wtihout tf * format * support for create_training_data * only when no splits and not tf * updated docs * added loading animation * only call for parquet format * use get(value)
* init batch scoring fail over * add comment
Beam support for java client
* added bigquery arrow flight storage connector * udpated comment * removed comment * addressed comments * added remove semicolon from query * removed quote
* added asof join * added to_string option for arrow_flight * added read options to external featuregroup * removed read_options again
* enable external support for bigquery * support GCS for external client * refactor and fix test * java changes for supporting bigquery external client * fix linting issues * fix linting issues * fix BQ storage connector test * refactor to write from bytes to file for key file * refactor to write from bytes to file for key file
Co-authored-by: Fabio Buso <fabio@hopsworks.ai>
* Add maven clean in java ut * Remove batch-mode * Fix storage connector tests
… a profile in hsfs (#1351)
… a profile in hsfs (logicalclocks#239)
* init-working * add lock changes * move lock to execute method * update lock * pass pool as arg * loop changes and refactoring * make new connection pool for each call * make exec_prep async and add lock * use context manager and refactor init connection * use create task * add semaphore * remove nest_async and use manual loop * make nest asyncio only if jupyter * refactoring and move hostname retrieving to init serving * minor clean * minor cleanup * add unit test * remove return of pool * revert locust changes and refactoring * revert locust changes and refactoring * fix review comments * fix review comments * remove loop method argument --------- Co-authored-by: Victor Jouffrey <37411285+vatj@users.noreply.github.com>
…ndency (#1344) * TYPE_CHECKING for fg and expectation suite * Adding constants for recurring error messages * More type_checking * Add more TYPE_CHECKING * Expectation Suite rely on Great Expectations only if installed * Add ge_installed check before reading data to run FG validation * more refactoring and import checks * Minor fixes * Change to import error and move to import checker to own file * Better to use modulenotfoundError * Switch import in test * refactor * fix unit tests * Throw module not found error if GE is not installed and Expectation Suite is expected to run * Add github actions to run pytest in an env with no great_expectations * Start skipping test which require great_expectations * Module not found error catch and skip in python engine * Add skipif to avoid error if GE installed * Apply code review * Update spark engine * Remove extra import * Fix extras * to see or not to see underscores * fix workflow pyspark * Test fixing autodoc * More testing to fix autodoc * Give up on docs * Fix HAS_GREAT_EXPECTATIONS in tests
`enableHiveSupport` on itself is a method, and has to be called to get a builder from it.
… path (#1358) * Append MATERIAL_DIRECTORY env var value to certificates path * Also include MATERIAL_DIR in token.jwt
* Fix test_base_client.py It was impure, changing environ variable and thereby messing other tests. This commit wraps these tests in a decorator saving and restoring os.environ. * Move changes_environ to tests/utils.py
* Refactor mysql dependencies out of util * Fix tests for mysql * Start cleaning some dependencies under type_checking
* Start removing hive related dependencies * More hive cleanups * Update ruff pre-commit hook * Start fixing pytest * REmove hive related tests * Review
…imary_key" (#1357) * primary_keys -> primary_key * backwards compatibility * backwards compatibility * Review and fix missed foc change --------- Co-authored-by: davitbzh <davit.bzhalava@gmail..com> Co-authored-by: Victor Jouffrey <vicatjou@gmail.com> Co-authored-by: Victor Jouffrey <37411285+vatj@users.noreply.github.com>
* feature logging * clean up * default write option * doc * fix * fix style * revert pd.StringDtype() * fix doc * fix doc * doc and copy df * get untransformed features * rename transformed_features * get untransformed features * return batch df * address comments * rename internal methods * fix style * add warning * fix circular import * set logging_enabled to True * fix style
aversey
force-pushed
the
the-merge-actions
branch
from
July 5, 2024 15:05
c6a50b2
to
5d198d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.