Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1481] Move basic things from hopsworks to hopsworks_common #245

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

aversey
Copy link
Contributor

@aversey aversey commented Jul 25, 2024

Namely: user.py, command.py, library.py, job_schedule.py, environment.py.

Requires #240 to be merged first.

JIRA Issue: FSTORE-1481

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@aversey aversey self-assigned this Jul 25, 2024
@aversey aversey mentioned this pull request Jul 25, 2024
3 tasks
@aversey aversey force-pushed the dedup-basic-hopsworks branch from 374f682 to fc44667 Compare July 26, 2024 11:57
@aversey aversey force-pushed the dedup-basic-hopsworks branch from fc44667 to 7919fc9 Compare July 26, 2024 11:58
@aversey aversey requested a review from robzor92 July 26, 2024 12:04
python/hopsworks_common/command.py Show resolved Hide resolved
python/hopsworks_common/command.py Show resolved Hide resolved
python/hopsworks_common/core/library_api.py Show resolved Hide resolved
python/hopsworks_common/environment.py Show resolved Hide resolved
python/hopsworks_common/job_schedule.py Show resolved Hide resolved
python/hopsworks_common/library.py Show resolved Hide resolved
python/hopsworks_common/user.py Show resolved Hide resolved
@robzor92 robzor92 self-requested a review July 26, 2024 13:30
@aversey aversey merged commit 7f17aeb into logicalclocks:main Jul 26, 2024
13 checks passed
@aversey aversey deleted the dedup-basic-hopsworks branch July 26, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants