[FSTORE-1606] Allow ´entries´ to be None while retrieving feature vectors from a feature view with only on-demand features #405
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in which dummy data needs to be provided using
entires
to the functionget_feature_vector
while retrieving feature vectors from a feature view with only on-demand features.Issue:
User have to always provide
entires
in the functionget_feature_vector
when reading feature vectors from a feature view.In the use case in which a feature view contains only on-demand features, all features are computed while retrieving feature vectors using provided request parameter. Hence
entries
is not a mandatory parameter.Fix Done:
Made
entries
into an optional parameter in cases where the feature view contains only on-demand features.JIRA Issue: https://hopsworks.atlassian.net/browse/FSTORE-1606
Priority for Review: -
Related PRs: https://github.com/logicalclocks/loadtest/pull/485
How Has This Been Tested?
Checklist For The Assigned Reviewer: