Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1606] Allow ´entries´ to be None while retrieving feature vectors from a feature view with only on-demand features #405

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

manu-sj
Copy link
Contributor

@manu-sj manu-sj commented Nov 19, 2024

This PR fixes an issue in which dummy data needs to be provided using entires to the function get_feature_vector while retrieving feature vectors from a feature view with only on-demand features.

Issue:
User have to always provide entires in the function get_feature_vector when reading feature vectors from a feature view.

In the use case in which a feature view contains only on-demand features, all features are computed while retrieving feature vectors using provided request parameter. Hence entries is not a mandatory parameter.

Fix Done:
Made entries into an optional parameter in cases where the feature view contains only on-demand features.

JIRA Issue: https://hopsworks.atlassian.net/browse/FSTORE-1606

Priority for Review: -

Related PRs: https://github.com/logicalclocks/loadtest/pull/485

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

Copy link
Contributor

@bubriks bubriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just minor feedback.

python/hsfs/core/vector_server.py Outdated Show resolved Hide resolved
python/hsfs/core/vector_server.py Outdated Show resolved Hide resolved
python/hsfs/core/vector_server.py Outdated Show resolved Hide resolved
@manu-sj manu-sj merged commit ef383bc into logicalclocks:main Nov 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants