Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSTORE-1574] Transformation functions bug fixes #412

Merged
merged 4 commits into from
Nov 28, 2024
Merged

[FSTORE-1574] Transformation functions bug fixes #412

merged 4 commits into from
Nov 28, 2024

Conversation

manu-sj
Copy link
Contributor

@manu-sj manu-sj commented Nov 26, 2024

This PR cherry picks #376.

JIRA Issue: https://hopsworks.atlassian.net/browse/FSTORE-1574

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@manu-sj manu-sj requested a review from robzor92 November 26, 2024 08:49
manu-sj and others added 2 commits November 28, 2024 13:53
@manu-sj
[FSTORE-1574] Transformation functions bug fixes (logicalclocks#376)
706efc4 
* peforming data validation after on-demand transformations are applied

* correcting error message for feature group transformations

* removing validations for on-deamnd features in Vector server as they are computed while retriving the featur evector

* adding tests for error messages

* adding warnings for transformation functions in external feature group and updating logger message

* correcting logging debug message
@manu-sj
bumping up hopsworks to 4.1.1
baa6f46
@SirOibaf SirOibaf enabled auto-merge (squash) November 28, 2024 22:52
@SirOibaf SirOibaf merged commit 7cc71ae into logicalclocks:branch-4.1 Nov 28, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirOibaf SirOibaf SirOibaf approved these changes

@robzor92 robzor92 Awaiting requested review from robzor92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manu-sj @SirOibaf