Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSTORE-1632] Change limit location for delta ingestion #422

Merged
merged 6 commits into from
Dec 6, 2024
Merged

[FSTORE-1632] Change limit location for delta ingestion #422

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eb6fa03
init
bubriks Dec 4, 2024
e4bc357
move update offsets
bubriks Dec 4, 2024
c2eac06
choose offsets based on limit
bubriks Dec 4, 2024
ac19f2d
fix
bubriks Dec 4, 2024
7db7c54
add job_limit
bubriks Dec 5, 2024
89fc412
Merge branch 'main' into FSTORE-1632
SirOibaf Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions utils/python/hsfs_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,22 +301,25 @@ def offline_fg_materialization(spark: SparkSession, job_conf: Dict[Any, Any], in
.option("includeHeaders", "true")
.option("failOnDataLoss", "false")
.load()
.limit(5000000)
)

# filter only the necassary entries
df = df.filter(expr("CAST(filter(headers, header -> header.key = 'featureGroupId')[0].value AS STRING)") == str(entity._id))
df = df.filter(expr("CAST(filter(headers, header -> header.key = 'subjectId')[0].value AS STRING)") == str(entity.subject["id"]))
filtered_df = df.filter(expr("CAST(filter(headers, header -> header.key = 'featureGroupId')[0].value AS STRING)") == str(entity._id))
filtered_df = filtered_df.filter(expr("CAST(filter(headers, header -> header.key = 'subjectId')[0].value AS STRING)") == str(entity.subject["id"]))

# limit the number of records ingested
limit = job_conf.get("write_options", {}).get("job_limit", 5000000)
filtered_df = filtered_df.limit(limit)

# deserialize dataframe so that it can be properly saved
deserialized_df = engine.get_instance()._deserialize_from_avro(entity, df)
deserialized_df = engine.get_instance()._deserialize_from_avro(entity, filtered_df)

# insert data
entity.stream = False # to make sure we dont write to kafka
entity.insert(deserialized_df, storage="offline")

# update offsets
df_offsets = df.groupBy('partition').agg(max('offset').alias('offset')).collect()
df_offsets = (df if limit > filtered_df.count() else filtered_df).groupBy('partition').agg(max('offset').alias('offset')).collect()
offset_dict = json.loads(offset_string)
for offset_row in df_offsets:
offset_dict[f"{entity._online_topic_name}"][f"{offset_row.partition}"] = offset_row.offset + 1
Expand Down
Loading