Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error message when kafka is not installed #441

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

aversey
Copy link
Contributor

@aversey aversey commented Dec 17, 2024

This PR adds/fixes/changes...

  • please summarize your changes to the code
  • and make sure to include all changes to user-facing APIs

JIRA Issue: -

Priority for Review: -

Related PRs: -

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Tests on VM

Checklist For The Assigned Reviewer:

- [ ] Checked if merge conflicts with master exist
- [ ] Checked if stylechecks for Java and Python pass
- [ ] Checked if all docstrings were added and/or updated appropriately
- [ ] Ran spellcheck on docstring
- [ ] Checked if guides & concepts need to be updated
- [ ] Checked if naming conventions for parameters and variables were followed
- [ ] Checked if private methods are properly declared and used
- [ ] Checked if hard-to-understand areas of code are commented
- [ ] Checked if tests are effective
- [ ] Built and deployed changes on dev VM and tested manually
- [x] (Checked if all type annotations were added and/or updated appropriately)

@aversey aversey requested a review from vatj December 17, 2024 11:36
@aversey aversey self-assigned this Dec 17, 2024
@aversey aversey enabled auto-merge (squash) December 17, 2024 15:04
@aversey aversey disabled auto-merge December 18, 2024 04:49
@aversey aversey force-pushed the fix-kafka-error-message branch from af3ceaa to 821b4b4 Compare December 18, 2024 04:49
@aversey aversey enabled auto-merge (squash) December 18, 2024 04:49
@aversey aversey merged commit 5d554d0 into logicalclocks:main Dec 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants