feat(core): add POST /saml-applications and DEL /saml-applications/:id APIs
#6822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/core/package.json | 📈 +182 Bytes |
| packages/core/src/routes/applications/application.ts | 📈 +15 Bytes |
| packages/core/src/routes/init.ts | 📈 +177 Bytes |
| packages/core/src/routes/swagger/utils/documents.ts | 📈 +100 Bytes |
| packages/core/src/routes/swagger/utils/general.ts | 📈 +1017 Bytes |
| packages/core/src/routes/well-known/well-known.openapi.ts | 📈 +1 Bytes |
| packages/core/src/saml-applications/libraries/secrets.ts | 📈 +915 Bytes |
| packages/core/src/saml-applications/libraries/utils.ts | 📈 +1.82 KB |
| packages/core/src/saml-applications/queries/configs.ts | 📈 +1.15 KB |
| packages/core/src/saml-applications/queries/secrets.ts | 📈 +1.31 KB |
| packages/core/src/saml-applications/routes/index.openapi.json | 📈 +3.2 KB |
| packages/core/src/saml-applications/routes/index.ts | 📈 +2.96 KB |
| packages/core/src/saml-applications/routes/utils.ts | 📈 +595 Bytes |
| packages/core/src/tenants/Libraries.ts | 📈 +177 Bytes |
| packages/core/src/tenants/Queries.ts | 📈 +342 Bytes |
| packages/integration-tests/src/api/saml-application.ts | 📈 +471 Bytes |
| packages/integration-tests/src/tests/api/application/application.test.ts | 📈 +6 Bytes |
| packages/integration-tests/src/tests/api/application/saml-application.test.ts | 📈 +2.74 KB |
| packages/phrases/src/locales/en/errors/application.ts | 📈 +207 Bytes |
| packages/schemas/src/types/index.ts | 📈 +39 Bytes |
| packages/schemas/src/types/saml-application.ts | 📈 +1.52 KB |
| packages/schemas/tables/saml_application_configs.sql | 📈 +69 Bytes |
| pnpm-lock.yaml | 📈 +942 Bytes |
darcyYe
force-pushed
the
yemq-add-post-saml-app-api
branch
3 times, most recently
from
71f4a15
to
e500da4
Compare
darcyYe
force-pushed
the
yemq-add-post-saml-app-api
branch
6 times, most recently
from
87665e1
to
2c8ef08
Compare
darcyYe
changed the title
POST /saml-applications and DEL /saml-applications/:id APIs
darcyYe
requested review from
simeng-li,
wangsijie and
gao-sun
as code owners
darcyYe
force-pushed
the
yemq-log-10113-add-saml-application-proxies-table
branch
from
97dfb47
to
c28b5dc
Compare
darcyYe
force-pushed
the
yemq-add-post-saml-app-api
branch
from
2c8ef08
to
9316ea2
Compare
darcyYe
force-pushed
the
yemq-log-10113-add-saml-application-proxies-table
branch
from
5554cf6
to
4e3a6a6
Compare
darcyYe
force-pushed
the
yemq-add-post-saml-app-api
branch
4 times, most recently
from
f767449
to
e618f18
Compare
darcyYe
force-pushed
the
yemq-log-10113-add-saml-application-proxies-table
branch
from
4e3a6a6
to
57a1561
Compare
darcyYe
force-pushed
the
yemq-log-10113-add-saml-application-proxies-table
branch
from
57a1561
to
6faece8
Compare
darcyYe
force-pushed
the
yemq-add-post-saml-app-api
branch
6 times, most recently
from
68bd363
to
901892b
Compare
Base automatically changed from
yemq-log-10113-add-saml-application-proxies-table
to
master
November 22, 2024 06:56
darcyYe
force-pushed
the
yemq-add-post-saml-app-api
branch
from
901892b
to
eef74b9
Compare
darcyYe
force-pushed
the
yemq-add-post-saml-app-api
branch
from
eef74b9
to
0795ba9
Compare
simeng-li
reviewed
Nov 22, 2024
Comment on lines
+35
to
+40
| secrets: SamlApplicationSecrets.guard | ||
| .omit({ | ||
| tenantId: true, | ||
| applicationId: true, | ||
| }) | ||
| .array(), |
There was a problem hiding this comment.
How about defining a specific API for the secret? I think this is how our application endpoints were designed.
| @@ -207,7 +213,7 @@ export const buildUserApiBaseDocument = ( | |||
| }); | |||
|
|
|||
| export const getSupplementDocuments = async ( | |||
| directory = 'routes', | |||
| directory = 'build', | |||
There was a problem hiding this comment.
might need some more context for this
|
|
||
| import { generateKeyPairAndCertificate } from './utils.js'; | ||
|
|
||
| export const createSamlApplicationSecretsLibrary = (queries: Queries) => { |
There was a problem hiding this comment.
Can we just keep one single SAML application library?
| samlApplicationSecrets: { insertSamlApplicationSecret }, | ||
| } = queries; | ||
|
|
||
| const createNewSamlApplicationSecretForApplication = async ( |
There was a problem hiding this comment.
How about just simply createSamlApplicationSecret or keyPairs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add following APIs:
This PR resolves LOG-10114 and LOG-10374, can find design here.
Testing
Add integration tests.
Checklist
.changeset